Skip to content

better fontSize disambiguation #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

better fontSize disambiguation #679

merged 2 commits into from
Jan 19, 2022

Conversation

@mbostock
Copy link
Member

@mbostock mbostock commented Jan 18, 2022

Fixes #378.

@mbostock mbostock requested a review from Fil January 18, 2022 19:04
Fil
Fil approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a minor nit

@mbostock @Fil
Update src/marks/text.js
ce4a69b 
Co-authored-by: Philippe Rivière <fil@rezo.net>
@mbostock mbostock merged commit 65ebe0c into main Jan 19, 2022
@mbostock mbostock deleted the mbostock/font-size branch January 19, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fil Fil Fil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow fontSize to be specified as a CSS length

3 participants

@mbostock @Fil