grid decoration mark #987
Closed
grid decoration mark #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #985.
I snuck the axes state into the existing context argument rather than adding yet another positional argument to mark.render. This allows the mark to access the axis.ticks option (whose default value is populated automatically by Plot). I could probably sneak this state somewhere else if you prefer, say in dimensions?
I chose to make this a decoration mark (with no data), but in theory we could make this a mark with automatic data based on the tick values, which would allow variable color, stroke-width, and everything else… which could be cool.
Also, maybe we could find a way to remove the grid functionality from the current axis, and instead have the existing scale.grid option translate into an implicit Plot.gridX or Plot.gridY mark being added?