Skip to content

absolute DuckDB FileAttachment URL #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023
Merged

absolute DuckDB FileAttachment URL #389

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b230481
Use an absolute URL to ingest FileAttachments in DuckDB.
Fil Nov 18, 2023
9d88421
simpler syntax
Fil Nov 18, 2023
b4898a4
Update src/duckdb.js
Fil Nov 26, 2023
f9f9b48
Revert "simpler syntax"
Fil Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/duckdb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ async function insertFile(database, name, file, options) {
const buffer = await file.arrayBuffer();
await database.registerFileBuffer(file.name, new Uint8Array(buffer));
} else {
await database.registerFileURL(file.name, url, 4); // duckdb.DuckDBDataProtocol.HTTP
await database.registerFileURL(file.name, new URL(url, location).href, 4); // duckdb.DuckDBDataProtocol.HTTP
}
const connection = await database.connect();
try {
Expand Down