-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
api: enforce tenant on generated time series
Currently, recording and alerting rules that are fetched from the new rules/raw API will not have any tenant label attached to them. This means that when the rules are configured on a Thanos Ruler, the time series that are generated will not have a tenant label on them. This is a big problem, because without this tenant label, the very tenant to whom the rules belong cannot query for the time series, making them in effect useless. This commit enforces that all rules returned by the rules/raw endpoint have a tenant_id label attached to them. Note: this is a distinct problem from ensuring that the rules written by a tenant are guaranteed to only include data from that tenant. Currently, the rules from a tenant can select data from any tenant. This is a distinct problem and should absolutely be tackled in a follow up. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Showing
3 changed files
with
76 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters