Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac releases after 0.1.1 are not working #30

Open
kevinearls opened this issue Jan 26, 2021 · 10 comments
Open

Mac releases after 0.1.1 are not working #30

kevinearls opened this issue Jan 26, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@kevinearls
Copy link
Contributor

I've downloaded all versions of the collector-builder from the releases page on my. None of them work after version 0.1.1. When I attempt to run them I just get "Killed: 9"

@jpkrohling
Copy link
Contributor

I don't have a Mac, would you be able to run the builder locally from the sources and test? If it fails, could you run a git bisect and see if the problem is in something we are doing? If go get works, it might mean that the problem is in the packaging process.

@jpkrohling jpkrohling added the bug Something isn't working label Jan 26, 2021
@kevinearls
Copy link
Contributor Author

Sure. How do I build though? I thought of that yesterday but didn't find instructions anywhere

@jpkrohling
Copy link
Contributor

go run should do it

@kevinearls
Copy link
Contributor Author

go run main.go works fine, as does go build main.go and running the executable it creates.

@jpkrohling
Copy link
Contributor

Could you go over the goreleaser and see if you can reproduce it? Or perhaps check the release logs and see if anything seems suspicious? One thing that could be broken is the upx command, to compact the binary.

@kevinearls
Copy link
Contributor Author

I installed goreleasor and upx on my mac and everything worked fine. (I actually built twice, once without upx installed so I could verify uncompressed builds.)

The difference may be that I used brew to install upx and that got me version 3.96 whereas we are getting 3.94 from the github action. I couldn't verify this completely as there is no 3.94 version of upx available via brew, and upx does not have darwin versions on their releases page.

@jpkrohling
Copy link
Contributor

Can you send a PR removing upx? We can then check whether that's the problem once we release the next version

mergify bot pushed a commit that referenced this issue Jan 27, 2021
Signed-off-by: Kevin Earls <kearls@redhat.com>
@jpkrohling
Copy link
Contributor

Releasing 0.4.1 with #31

@kevinearls
Copy link
Contributor Author

@jpkrohling The mac download now works

@jpkrohling
Copy link
Contributor

It was indeed upx then. There's a list of all the software used by Github workers by version of the operating system. If we are using ubuntu-latest, it might really be the latest yet (20-04?). At least until recently, latest pointed to 18.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants