feat: synchronize github secrets to secretsmanager #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more convenient to manage secrets in github than to interact with AWS secretsmanager. Unfortunately, doing so naively would make it impossible for an operator to run terraform manually if a complex state operation were to be necessary. As a workaround, we can ensure that secrets with prefix X_ are synchronized to secretsmanager on every workflow run.
obs-gh-nikhildua
approved these changes
Apr 10, 2024
|
Any chance we can test this with an example repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more convenient to manage secrets in github than to interact with AWS secretsmanager. Unfortunately, doing so naively would make it impossible for an operator to run terraform manually if a complex state operation were to be necessary. As a workaround, we can ensure that secrets with prefix X_ are synchronized to secretsmanager on every workflow run.