Don't work when .git placed in parent directory

[galkinrost]

Hi! Thanks for amazing solution of hooks implementation for node.js. But could you add support for cases when .git placed in parent directory relative to package.json?

[villelahdenvuo]

👍

[davidchase]

👍

[3rd-Eden]

@Swaagie Any thoughts on this? I'm neutral about it.

[roman01la]

👍 I have different parts of the project in separate directories within a single repo, this will solve the issue.

[3rd-Eden]

I guess we could make this functionality opt-in by specifying the max depth that we can search for a .git folder.

[villelahdenvuo]

The only complication I can see, if I have multiple projects in a repository in subfolders that use pre-commit.

[3rd-Eden]

@tuhoojabotti That's why I'm suggesting opt-in through a field in the package.json

[villelahdenvuo]

Yeah, I don't see an issue with that, but would it be possible to run the pre-commit hooks of all packages in sub folders? For example if I have a package.json file for both my back-end and front-end I would like to run both pre-commit hooks before allowing commit.

[metaman]

👍

[katmai7]

+1

[trevordmiller]

+1

[kosmotaur]

Happy to give it a shot and create a PR. Could I get a hint please which part of the code to start with?

EDIT: not going to do that, was easier to just change my directory structure 😜

[3rd-Eden]

@kosmotaur Probably the installation script of this module: https://github.com/observing/pre-commit/blob/master/install.js#L23-L28 as it checks if the parent folder has .git