Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dep to remove warn about cross-spaw #76

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Update dep to remove warn about cross-spaw #76

merged 2 commits into from
Jul 25, 2016

Conversation

luanmuniz
Copy link
Contributor

With this the following warn is fixed

npm WARN deprecated cross-spawn-async@2.2.4: cross-spawn no longer requires a build toolchain, use it instead!

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage remained the same at 95.413% when pulling 33f0273 on luanmuniz:master into fec48cb on observing:master.

@3rd-Eden
Copy link
Member

Error: In order to use spawnSync on node 0.10 or older, you must install spawn-sync

So it needs to have the spawn-sync module installed as well in order to not break backwards compatibility.

@luanmuniz
Copy link
Contributor Author

Is there any interest in doing this after the TLS for 0.10 and 0.12 ends?

@3rd-Eden
Copy link
Member

Well all that is needed is to add spawn-sync to the dependencies and it should just pass the tests again.

@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 95.413% when pulling 58a4511 on luanmuniz:master into fec48cb on observing:master.

@luanmuniz
Copy link
Contributor Author

@3rd-Eden You are right, sorry. i was reading the name of this module and thinking on another. Just added the dependence.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.413% when pulling 69e8b0e on luanmuniz:master into fec48cb on observing:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 95.413% when pulling 69e8b0e on luanmuniz:master into fec48cb on observing:master.

@3rd-Eden 3rd-Eden merged commit 7154dee into observing:master Jul 25, 2016
@3rd-Eden
Copy link
Member

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants