Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Feature/custom header #34

Merged
merged 33 commits into from
Feb 3, 2020
Merged

Feature/custom header #34

merged 33 commits into from
Feb 3, 2020

Conversation

jk-gan
Copy link
Member

@jk-gan jk-gan commented Jan 2, 2020 •
edited by plwai
Loading

Resolve #30

  • Add header method to add one custom header
  • Add set_headers method to add multiple headers at once
  • Re-implement json, file response to support custom headers
  • Documentation
  • Testing

@jk-gan jk-gan self-assigned this Jan 2, 2020
@jk-gan jk-gan added the enhancement Enchancement for current feature label Jan 2, 2020
@jk-gan jk-gan added this to the V0.2 milestone Jan 2, 2020
@jk-gan jk-gan force-pushed the feature/custom_header branch from 537bba1 to 9192de0 Compare January 5, 2020 01:27
jk-gan added 19 commits January 5, 2020 19:33
@jk-gan
test: add more test cases
533235d
@jk-gan
refactor: refactor responder implementation
cc4293c
@jk-gan
refactor: make response::json return CustomResponder so we can chain …
96d4684 
…all the method from Responder and CustomResponder
@jk-gan
feat: add header function for Responder
853a2c8
@jk-gan
feat: add initial implementation to convert headers from CustomRespon…
049220c 
…der into Response headers
@jk-gan
refactor: refactor codes to reduce duplication
a174af8
@jk-gan
refactor: ignore None headers case instead of panic it
68b921a
@jk-gan
feat: add initial implementation for adding multiple headers at once
51eb822
@jk-gan
feat: add few test cases for responder
8ffcb90
@jk-gan
test: add more test cases
36b7021
@jk-gan
refactor: refactor responder implementation
fca4f9a
@jk-gan
refactor: make response::json return CustomResponder so we can chain …
d0365f5 
…all the method from Responder and CustomResponder
@jk-gan
feat: removed CustomResponder and added a Response struct to handle c…
a56eca7 
…ustom Responder
@jk-gan
chore: merge with origin
ae37763
@jk-gan
feat: add response html method
22e16b7
@jk-gan
refactor: refactor the syntax for some common status
25660ba
@jk-gan
feat: now user can set custom header with string key
d859cb8
@jk-gan
feat: add method to add headers string for response
e969cda
@jk-gan
fix: fix clyppy errors
78c196a
@jk-gan jk-gan marked this pull request as ready for review February 2, 2020 08:18
@jk-gan jk-gan requested a review from plwai February 3, 2020 12:53
plwai
plwai reviewed Feb 3, 2020
View reviewed changes
plwai
plwai reviewed Feb 3, 2020
View reviewed changes
plwai
plwai reviewed Feb 3, 2020
View reviewed changes
plwai
plwai reviewed Feb 3, 2020
View reviewed changes
@plwai
Copy link
Member

plwai commented Feb 3, 2020

Other than those minor warnings. Looks good for me.

@jk-gan
Copy link
Member Author

jk-gan commented Feb 3, 2020

@plwai review again

@jk-gan jk-gan merged commit c5fbe93 into develop Feb 3, 2020
@jk-gan jk-gan deleted the feature/custom_header branch February 3, 2020 16:50
@plwai plwai mentioned this pull request Apr 2, 2020
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@plwai plwai plwai approved these changes

Assignees

@jk-gan jk-gan

Labels
enhancement Enchancement for current feature
Projects
None yet
Milestone
V0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jk-gan @plwai