test: test LayoutOptions with the full task from TaskBuilder
#2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilandikov
force-pushed
the
layout-options-with-full-task
branch
from
c25ce5e to
e90d4b0
Compare
|
Sorry for the delay in getting to this. When/if you have time, please could you rebase it? I'm not expecting any conflicts: 🤞 |
claremacrae
added
the
scope: rendering of tasks
…eateFullyPopulatedTask()
…eFullyPopulatedTask()
…r.createFullyPopulatedTask()
…ilder.createFullyPopulatedTask()
Same date as in TaskBuilder.createFullyPopulatedTask()
…lder.createFullyPopulatedTask()
Same date as in TaskBuilder.createFullyPopulatedTask()
Same date as in TaskBuilder.createFullyPopulatedTask()
This is a copy of testLayoutOptions() for now, will be simplified
It is unused in the tests where testLayoutOptionsFromLine is used
It will be assumed as `new LayoutOptions()` in renderListItem()
It will be deleted
This way the test order follows the order of rendered components
ilandikov
force-pushed
the
layout-options-with-full-task
branch
from
e90d4b0 to
3b4b390
Compare
Done =) |
claremacrae
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LayoutOptions are now tested with a hardcoded task. With this PR the test task is taken from
TaskBuilder.createFullyPopulatedTask()and the task line parameter is removed from the test helper.Motivation and Context
TaskBuilder.createFullyPopulatedTask()with// NEW_TASK_FIELD_EDIT_REQUIRED), so the tests are strongerCreatedDatefield is missing in some tests...How has this been tested?
Breaking unit tests.
Types of changes
Internal changes:
test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms