Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial support for Cancelled Date field #2550

Merged
merged 23 commits into from
Dec 31, 2023
Merged

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Dec 31, 2023

Description

This adds initial support for Cancelled Date field.

The following are supported and documented:

  • Reading and writing Cancelled date, in Tasks Emoji and Dataview formats
  • Auto-adding and removing the cancelled date
    • Automatically adding the Cancelled Date when changing the status to Cancelled
    • Automatically removing the Cancelled Date when changing the status from Cancelled
  • Disabling auto-adding of Cancelled Date in Settings
  • Rendering of the Cancelled date in Tasks search results - and styling based on cancelled date values

Sample tasks, in both formats:

- [-] #task Has a cancelled date ❌ 2023-04-18
- [-] #task Has a cancelled date  [cancelled:: 2023-04-18]

Not yet supported:

  • Seeing the Cancelled Date in Edit Task Modal
  • show/hide cancelled
  • filtering, sorting and grouping by cancelled
  • using the cancelled date in custom filters and groups

Motivation and Context

First stage of implementing #1855.

How has this been tested?

  • New tests
  • Manual exploratory testing

Screenshots (if appropriate)

image

Types of changes

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Documentation (prefix: docs - improvements to any documentation content for users)
  • Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

Removes cancelled date from the new task
I'm used to seeing Done Date at the end of the line, and feel
it makes sense to keep this pattern.

In real-world tasks, I don't think many will have both
Cancelled and Done dates, so this probably only affects
Jest tests and documentation.
@claremacrae claremacrae added scope: task dates and times Requests for enhancements to types and formats of dates and times associated with tasks scope: parsing markdown See also 'scope: global filter' labels Dec 31, 2023
@claremacrae
Copy link
Collaborator Author

I've asked for feedback on this in #1855.

@claremacrae claremacrae merged commit 88dbe97 into main Dec 31, 2023
2 checks passed
@claremacrae claremacrae deleted the cancelled-date branch December 31, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: parsing markdown See also 'scope: global filter' scope: task dates and times Requests for enhancements to types and formats of dates and times associated with tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant