Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add editing of Created, Done and Cancelled dates in Modal #2557

Merged
merged 34 commits into from
Jan 1, 2024
Merged

feat: Add editing of Created, Done and Cancelled dates in Modal #2557

merged 34 commits into from
Jan 1, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

I needed to add the display of Cancelled date, and just couldn't get the layout looking good alongside Completed, Done and Created fields.

So I decided to go ahead and add editing of these fields instead.

Changes made:

  • Add editing of Created, Done and Cancelled dates in Modal
    • Note: there are no accelerator keys for these fields yet.
  • Added basic automated tests of these fields
  • Updated documentation for these changes.
    • The Edit Task modal screenshot was quite out of date, not having Highest and Lowest priorities in.

Motivation and Context

How has this been tested?

  • Running existing tests
  • Added automated tests for the 'happy path' of date editing in the modal
  • Manual exploratory testing

Screenshots (if appropriate)

image

Types of changes

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae
feat: First try at showing Cancelled Date in Edit Task Modal
dddfefe 
The layout is poor and needs to be improved.
@claremacrae
feat: Better layout of the read-only date values
6fad786 
They are now one-per row, and show their emojis.

This required creating a new CSS class tasks-modal-readonly-dates
which unfortunately has some copied-and-pasted CSS from tasks-modal-dates.
@claremacrae
feat: Allow Created, Cancelled and Due dates to be edited
95f9347 
Their values are not populated automatically yet.
@claremacrae
fix: Fix validation of Done, Created and Cancelled dates
db92f9e
@claremacrae
test: - Add first test of date field in EditTask modal
4039a0f
@claremacrae
test: . Extract method getAndCheckRenderedElement()
7d6b5f3
@claremacrae
test: - Re-use getAndCheckRenderedElement()
880509a
@claremacrae
test: . Rename expectedDueDate to expectedElementValue
74d0153
@claremacrae
test: . Rename renderedDueDate to inputElement
2c6b277
@claremacrae
test: . Extract method testElementRender()
e607f1b
@claremacrae
test: . Extract variable line
f5689ff
@claremacrae
test: . Inline one call to getAndCheckRenderedDescriptionElement()
74ba871
@claremacrae
test: - Re-implement testDescriptionRender() using testElementRender()
30ffd5f
@claremacrae
test: . inline variables in 'should display a valid due date' test
92416b2
@claremacrae
test: - Test display of all date fields in Edit task modal
0d736d1
@claremacrae
test: - Test invalid date value in all date fields in Edit task modal
1a2fe89
@claremacrae
test: . Generify parameter names in editDescriptionAndSubmit()
2abf8a8
@claremacrae
test: . Rename editDescriptionAndSubmit() to editInputElementAndSubmit()
a05b364
@claremacrae
test: - Duplicate an existing test, preparing to make more flexible
92a6db0
@claremacrae
test: . Inline one call to testDescriptionEdit()
daf7898
@claremacrae
test: - Duplicate editTaskLine() - preparing to make it more flexible
ab624c8
@claremacrae
test: . Inline one call to getAndCheckRenderedDescriptionElement()
cba598c
@claremacrae
test: . Extract parameter elementId
b49ce5c
@claremacrae
test: . Inline redundant string templates
cec7077
@claremacrae
test: . Rename parameter to newValue
39381ee
@claremacrae
test: - Simplify editTaskLine2() - remove special case code for descr…
a9a7e0f 
…iption
@claremacrae
test: . Improve parameter order in editTaskLine2()
8f75ae8
@claremacrae
test: - Test editing and saving of due date
9969fa5
@claremacrae
test: - Start a new describe block for editing dates
0a60de3
@claremacrae
test: - Test editing of all date fields in Edit task modal
b676b93
@claremacrae claremacrae added scope: task dates and times Requests for enhancements to types and formats of dates and times associated with tasks scope: edit task The Create or edit task modal/dialog labels Jan 1, 2024
@claremacrae claremacrae merged commit 9c14800 into main Jan 1, 2024
2 checks passed
@claremacrae claremacrae deleted the edit-created-and-done branch January 1, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: edit task The Create or edit task modal/dialog scope: task dates and times Requests for enhancements to types and formats of dates and times associated with tasks
Projects
Tasks (Obsidian plugin) Roadmap
Status: 🎉 Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@claremacrae