fix: 'sort by function' now sorts 'true' before 'false'

[claremacrae]

This makes the results easier to reason about, and easier to document.

Description

Change sort by function for boolean expressions so that tasks are now sorted in the order:

1. tasks giving expression value true come first
2. then all the tasks giving expression value false are listed.

Previously I opted to sort the opposite way round, but this turned out to be confusing in use.

Sorting recurring tasks first, Before:

One had to know to use either of these:

sort by function ! task.isRecurring
sort by function reverse task.isRecurring

Sorting recurring tasks first, Now:

Now this works:

sort by function task.isRecurring

It feels logical to me that the tasks that match the boolean expression are the ones that are shown first.

Motivation and Context

This is another part of fixing #1479 - and trying to get the work I did in #2577 ready for release.

It will also make the docs for sort by function easier to write.

How has this been tested?

• Updating tests
• Exploratory testing

Screenshots (if appropriate)

Types of changes

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • ... of an unreleased feature
• Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

• Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• My change has adequate Unit Test coverage.

Terms

• My contribution follow this project's contributing guide
• I agree to follow this project's Code of Conduct