fix!!: Make default sort order sort first by status type #2599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DONE
tasks were often sorted before currentIN_PROGRESS
andDONE
tasks.I've documented this as a fix that is potentially a breaking change, just because it is so fundamental.
But it's clearly an improvement.
Motivation and Context
Fixes #439
How has this been tested?
Screenshots (if appropriate)
Here is a screenshot of the changes in sort order for a sample selection of tasks in the tests.
In the new order, the tasks are clearly sorted in order
IN_PROGRESS
,TODO
,DONE
,CANCELLED
thenNON_TASK
.Types of changes
Changes visible to users:
feat!!
orfix!!
- fix or feature that would cause existing functionality to not work as expected)docs
- improvements to any documentation content for users)Internal changes:
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test
- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint
.Terms