Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!!: Make default sort order sort first by status type #2599

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

  • Document the default sort order
  • Fix problem that old, high-priority DONE tasks were often sorted before current IN_PROGRESS and DONE tasks.

I've documented this as a fix that is potentially a breaking change, just because it is so fundamental.

But it's clearly an improvement.

Motivation and Context

Fixes #439

How has this been tested?

  • Via approval tests to visualise the change in behaviour.
  • Exploratory testing.

Screenshots (if appropriate)

Here is a screenshot of the changes in sort order for a sample selection of tasks in the tests.

In the new order, the tasks are clearly sorted in order IN_PROGRESS, TODO, DONE, CANCELLED then NON_TASK.

image

Types of changes

Changes visible to users:

  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae claremacrae added the scope: sorting Changes to the sorting capabilities label Jan 18, 2024
@claremacrae claremacrae merged commit ff8cd81 into main Jan 18, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-default-sort-order branch January 18, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: sorting Changes to the sorting capabilities
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

Since getting to 1.4.1 task order changes when completing a task
1 participant