refactor: Reduce cyclic dependencies in src/ #2612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce cyclic dependencies between source files, by:
Priority
andTaskRegularExpressions
out ofTask.ts
getPrintableSymbol()
fromStatusRegistryReport.ts
toStatusSettingsReport.ts
I decided to version control
circular-deps.txt
for a while, to keep an eye on any growth of cyclic dependencies. It does have the annoyance that it contains a flickering time measurement, but I'm assuming it's likely only me and @ilandikov who might run it, and we can try and revert any changes if the only difference is from running the tool and getting a differing timing.The file can be updated with:
And see the similar
Motivation and Context
It's kind of a constant process of trying to simplify code by reducing these dependencies. See #1402 for an earlier attempt.
How has this been tested?
Screenshots (if appropriate)
Before and after:
Types of changes
Internal changes:
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)Checklist
yarn run lint
.Terms