Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dataview-format parses 'Task.id' and 'Task.dependsOn' same as emoji #2671

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

Several fixes to the parsing of ids and dependsOn values in dataview format.

  • dependsOn is now read
  • dependsOn now allows capitals in IDs
  • id now allows capitals in IDs

This makes these fields consistent with the parsing of Tasks Emoji format.

Motivation and Context

Fixes #2667, and some other issues found when writing tests

How has this been tested?

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
    • This was a fix to a not-yet released feature.

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added scope: task dependencies Anything to do with making tasks aware of other tasks scope: parsing markdown See also 'scope: global filter' labels Feb 21, 2024
@claremacrae claremacrae merged commit 5800b5a into main Feb 21, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-dataview-dependsOn branch February 21, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: parsing markdown See also 'scope: global filter' scope: task dependencies Anything to do with making tasks aware of other tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependsOn values not read in Dataview format
1 participant