Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop writing Variant Selector 16 on dependsOn emojis - ⛔ #2697

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Mar 7, 2024

Description

Don't add an invisible character (Variant Selector 16) to the end of the ⛔ emoji, for dependsOn values.

And remove all Variant Selector 16 except those that are necessary for tests.

Motivation and Context

Fix an issue which was discovered when investigating #2693.

How has this been tested?

  • Via automated test
  • Via manual exploratory testing

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • Documentation (prefix: docs - improvements to any documentation content for users)
  • Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae claremacrae added scope: parsing markdown See also 'scope: global filter' scope: emojis and signifiers Anything to do with emojis and signifiers labels Mar 7, 2024
@claremacrae claremacrae merged commit f138b16 into main Mar 7, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-no-vs16-on-dependsOn branch March 7, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: emojis and signifiers Anything to do with emojis and signifiers scope: parsing markdown See also 'scope: global filter'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant