Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: postpone to current date keeps postpone button active #3076

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: postpone to current date keeps postpone button active #3076

merged 1 commit into from
Sep 13, 2024

Conversation

ilandikov
Copy link
Collaborator

@ilandikov ilandikov commented Sep 11, 2024 •
edited
Loading

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Description

  • do nothing when the task date to postpone and the postponed date match (this is a case when a date field is postponed to a date that is already set in the postpone menu)

Motivation and Context

How has this been tested?

  • manual test in demo vault:
    • set scheduled date to today
    • right click on postpone menu, today's date is checked
    • click on today's date
    • verify that right click on postpone still works
    • verify that left click on postpone still works
    • repeat the test with tomorrow date

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.
    • nope, manual test

Terms

@ilandikov ilandikov added scope: user interface Changes to parts of UI other the Edit task modal. See also "scope: edit task" scope: postpone The ⏩ Postpone button and its right-click context menu, for postponing tasks labels Sep 11, 2024
@ilandikov ilandikov changed the title fix: postpone to set date fix: postpone to set date keeps the postpone button "alive" Sep 11, 2024
@claremacrae claremacrae changed the title fix: postpone to set date keeps the postpone button "alive" fix: postpone to current date keeps postpone button active Sep 12, 2024
@ilandikov ilandikov force-pushed the fix-postpone-to-set-date branch from 2deb31d to 700adc5 Compare September 13, 2024 06:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

claremacrae
claremacrae approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

I'm sure the answer's yes, but can you confirm you repeated the manual tests?
If so, I'll just go ahead and merge...

@ilandikov
Copy link
Collaborator Author

This looks great.

I'm sure the answer's yes, but can you confirm you repeated the manual tests? If so, I'll just go ahead and merge...

Yes, of course, I also double confirmed that right now

@claremacrae claremacrae merged commit e1519f7 into obsidian-tasks-group:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claremacrae claremacrae claremacrae approved these changes

Assignees
No one assigned
Labels
scope: postpone The ⏩ Postpone button and its right-click context menu, for postponing tasks scope: user interface Changes to parts of UI other the Edit task modal. See also "scope: edit task"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postpone today/tomorrow button becomes inactive after selecting the option for the current date value
2 participants
@ilandikov @claremacrae