refactor: Replace Status factory functions with static objects

[ilandikov]

Types of changes

Internal changes:

• Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
• Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

• Status.make*() are same as the existing Status.* calls (* is any status), so
  • Replace Status.make*() status methods with existing Status.* static class fields
  • For other statuses, refactor Status.make*() method calls to Status.* static class fields

For reference: existing Status.* static class fields were calling Status.make*() methods, so the behaviour was same.

Note from @claremacrae: the behaviour differed in how many Status instances were created, however.

Motivation and Context

• remove code duplication and use shorter calls to Status static methods
• better code

How has this been tested?

• unit tests

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change has adequate Unit Test coverage.

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[claremacrae]

Looking at how little code has changed in src, and most of the changes being in tests, it may be that my slight doubts are irrelevant!