Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add experimental 'show/hide tree' instruction - disabled by default #3128

Merged
merged 8 commits into from
Oct 19, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Oct 18, 2024

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Warning: These instructions may be removed or renamed, and are not (yet) intended for end-user use.

Add two new experimental - and undocumented instructions:

show tree
hide tree

show tree causes Tasks to render nested tasks and list items, and is off by default.

I am not sure whether hide tree is really the right vocabulary for this long-term, but it is definitely better than hide children which was the first thing I tried.

Motivation and Context

More work on:

This will allow me to continue making Tasks releases whilst we improve the rendering of nested lines.

How has this been tested?

  • Automated tests
  • Exploratory tests

Checklist

Terms

@claremacrae claremacrae added scope: rendering of tasks How the plugin displays tasks (except CSS issues) scope: show/hide The show and hide instructions in Tasks query blocks labels Oct 18, 2024
@claremacrae claremacrae requested a review from ilandikov October 18, 2024 21:56
@claremacrae
Copy link
Collaborator Author

Hi @ilandikov - this is just FYI... I'll need to merge it to do a release soon anyway...

Copy link
Collaborator

@ilandikov ilandikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm approving with comments in the interest of time. Feel free to resolve them by yourself, I don't want to block this.

src/Renderer/QueryResultsRenderer.ts Show resolved Hide resolved
src/Query/Query.ts Outdated Show resolved Hide resolved
src/Query/Query.ts Show resolved Hide resolved
@claremacrae claremacrae changed the title feat: Add experimental 'show/hide children' instruction - disabled by default feat: Add experimental 'show/hide tree' instruction - disabled by default Oct 19, 2024
Copy link

@claremacrae claremacrae merged commit d732bbb into main Oct 19, 2024
3 checks passed
@claremacrae claremacrae deleted the add-show-hide-children branch October 19, 2024 21:08
@claremacrae claremacrae added the scope: sub-tasks and super-tasks nested/parent/child: controlling their display, filtering them, and similar label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: rendering of tasks How the plugin displays tasks (except CSS issues) scope: show/hide The show and hide instructions in Tasks query blocks scope: sub-tasks and super-tasks nested/parent/child: controlling their display, filtering them, and similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants