-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add experimental 'show/hide tree' instruction - disabled by default #3128
Conversation
Hi @ilandikov - this is just FYI... I'll need to merge it to do a release soon anyway... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm approving with comments in the interest of time. Feel free to resolve them by yourself, I don't want to block this.
|
Types of changes
Changes visible to users:
feat
- non-breaking change which adds functionality)vault
- improvements to the Tasks-Demo sample vault)Internal changes:
test
- additions and improvements to unit tests and the smoke tests)Description
Warning: These instructions may be removed or renamed, and are not (yet) intended for end-user use.
Add two new experimental - and undocumented instructions:
show tree
causes Tasks to render nested tasks and list items, and is off by default.I am not sure whether
hide tree
is really the right vocabulary for this long-term, but it is definitely better thanhide children
which was the first thing I tried.Motivation and Context
More work on:
This will allow me to continue making Tasks releases whilst we improve the rendering of nested lines.
How has this been tested?
Checklist
yarn run lint
.Terms