Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow browser docks to arbitrarily close OBS #427

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

WizardCM
Copy link
Member

Description

This overrides the built-in window.close of Chromium with a no-op.

I tried alternatives that weren't as hacky, however they either aren't cancellable or didn't specify which frame made the request (or the reason for the close request).

Motivation and Context

Certain third party browser docks call window.close for whatever reason, which causes OBS to close. We don't approve.

How Has This Been Tested?

Open a browser dock.
Right click and Inspect.
Type window.close() in the Console.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Nov 11, 2023
@Lain-B Lain-B merged commit 36508a9 into obsproject:master Nov 12, 2023
1 check passed
@WizardCM WizardCM deleted the dont-close-cef branch December 10, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants