Don't allow browser docks to arbitrarily close OBS #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This overrides the built-in
window.close
of Chromium with a no-op.I tried alternatives that weren't as hacky, however they either aren't cancellable or didn't specify which frame made the request (or the reason for the close request).
Motivation and Context
Certain third party browser docks call
window.close
for whatever reason, which causes OBS to close. We don't approve.How Has This Been Tested?
Open a browser dock.
Right click and Inspect.
Type
window.close()
in the Console.Types of changes
Checklist: