Skip to content

Commit

Permalink
cmake/plugins: Enable -Wswitch on GCC
Browse files Browse the repository at this point in the history
This warning is already enabled for Clang which causes issue for things
that are usually built with MSVC or GCC (e.g. non-macOS plugins).

obs-nvenc switch warning is also fixed in this commit.
obs-qsv11 has switch warning set to not become errors.
  • Loading branch information
tytan652 committed Oct 25, 2024
1 parent e8968ba commit 2cc916a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions cmake/linux/compilerconfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ set(
-Wno-unused-function
-Wno-unused-label
-Wparentheses
-Wswitch
-Wuninitialized
-Wunreachable-code
-Wunused-parameter
Expand Down
1 change: 1 addition & 0 deletions plugins/obs-nvenc/nvenc-helpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ const char *nv_error_name(NVENCSTATUS err)
RETURN_CASE(NV_ENC_ERR_RESOURCE_REGISTER_FAILED);
RETURN_CASE(NV_ENC_ERR_RESOURCE_NOT_REGISTERED);
RETURN_CASE(NV_ENC_ERR_RESOURCE_NOT_MAPPED);
RETURN_CASE(NV_ENC_ERR_NEED_MORE_OUTPUT);
}
#undef RETURN_CASE

Expand Down
7 changes: 7 additions & 0 deletions plugins/obs-qsv11/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ target_sources(

target_compile_definitions(obs-qsv11 PRIVATE $<$<PLATFORM_ID:Windows>:DX11_D3D>)

target_compile_options(
obs-qsv11
PRIVATE
$<$<COMPILE_LANG_AND_ID:C,GNU,Clang>:-Wno-error=switch>
$<$<COMPILE_LANG_AND_ID:CXX,GNU,Clang>:-Wno-error=switch>
)

target_link_libraries(
obs-qsv11
PRIVATE
Expand Down

0 comments on commit 2cc916a

Please sign in to comment.