Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTL Removal #10019

Merged
merged 7 commits into from
Jul 29, 2024
Merged

FTL Removal #10019

merged 7 commits into from
Jul 29, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented Dec 19, 2023

Description

Removes FTL output, services, etc.

Motivation and Context

Per #4021 removal is due soon™

This PR shall also serve as a reminder for any services that still rely on FTL support in OBS that they shouldn't.

How Has This Been Tested?

Still builds!

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added Code Cleanup Non-breaking change which makes code smaller or more readable Services These are modifications to the Service list and are not tied to the release schedule labels Dec 19, 2023
@RytoEX RytoEX self-assigned this Dec 19, 2023
@tytan652
Copy link
Collaborator

tytan652 commented Jan 6, 2024 •
edited
Loading

Since the PR remove YouNow, you should remove obs-studio/plugins/rtmp-services/service-specific/younow.h and obs-studio/plugins/rtmp-services/service-specific/younow.c.

@derrod derrod added this to the OBS Studio (Next Major Version) milestone Apr 7, 2024
@derrod derrod marked this pull request as ready for review July 13, 2024 23:04
@derrod
Copy link
Member Author

derrod commented Jul 14, 2024

Since the PR remove YouNow, you should remove obs-studio/plugins/rtmp-services/service-specific/younow.h and obs-studio/plugins/rtmp-services/service-specific/younow.c.

Done.

RytoEX
RytoEX approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll have to juggle this around a few other PRs.

@RytoEX RytoEX merged commit b9f6363 into obsproject:master Jul 29, 2024
15 checks passed
@derrod derrod deleted the remove-ftl branch July 29, 2024 20:47
@umlaeute umlaeute mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

Assignees

@RytoEX RytoEX

Labels
Code Cleanup Non-breaking change which makes code smaller or more readable Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Milestone
OBS Studio 31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@derrod @tytan652 @RytoEX