Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Set minimum version for nlohmann_json to 3.11 #11384

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Oct 11, 2024

Description

We know this is the minimum version that we require, so we can just fail during configure if somehow an older version is found.

Motivation and Context

See:

Although we no longer support Ubuntu 22.04 for building or running OBS Studio, we can make the dependency requirement here more obvious at configure time.

Either "UI: " or "cmake: " seemed like acceptable commit prefixes, but I went with UI for now.

How Has This Been Tested?

Tested locally on Windows.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

We know this is the minimum version that we require, so we can just fail
during configure if somehow an older version is found.
@RytoEX RytoEX added Enhancement Improvement to existing functionality Code Cleanup Non-breaking change which makes code smaller or more readable labels Oct 11, 2024
@RytoEX RytoEX requested review from derrod and PatTheMav October 11, 2024 19:36
@RytoEX RytoEX added this to the OBS Studio 31 milestone Oct 15, 2024
@RytoEX RytoEX merged commit 77d74dd into obsproject:master Oct 15, 2024
14 checks passed
@RytoEX RytoEX deleted the set-minimum-nlohmann-json-version branch October 15, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants