various: Remove HAVE_OBSCONFIG_H ifdefs #11472
Open
+2
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
HAVE_OBSCONFIG_H
ifdef-checks and marks the definition for removal in 32.0 (as removing it could be considered a breaking change, in case there are any third-party plugins checking for it).Motivation and Context
With the removal of all legacy code paths,
obsconfig.h
always exists and theHAVE_OBSCONFIG_H
compile definition always gets set. As such, it's no longer necessary to check for it.How Has This Been Tested?
Tested with CI that all builds still compile.
Tested with
git grep
that the definition line in cmake is now the only instance remaining ofHAVE_OBSCONFIG_H
.Types of changes
Checklist: