Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: Remove HAVE_OBSCONFIG_H ifdefs #11472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented Nov 1, 2024

Description

Removes HAVE_OBSCONFIG_H ifdef-checks and marks the definition for removal in 32.0 (as removing it could be considered a breaking change, in case there are any third-party plugins checking for it).

Motivation and Context

With the removal of all legacy code paths, obsconfig.h always exists and the HAVE_OBSCONFIG_H compile definition always gets set. As such, it's no longer necessary to check for it.

How Has This Been Tested?

Tested with CI that all builds still compile.
Tested with git grep that the definition line in cmake is now the only instance remaining of HAVE_OBSCONFIG_H.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

With the removal of all legacy code paths, obsconfig.h always exists and
the compile definition always gets set. As such, it's no longer
necessary to check for it.
As removing the definition itself could be seen as a breaking change,
this simply adds a comment to it to, marking it for removal in the next
major version.
@gxalpha gxalpha added the Code Cleanup Non-breaking change which makes code smaller or more readable label Nov 1, 2024
@norihiro
Copy link
Contributor

norihiro commented Nov 2, 2024

I'm sorry that there is no module name various which is written in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants