frontend: Reorganize Preview/Source context menu #11492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizardCM
added
Enhancement
Warchamp7
force-pushed
the
preview-context-menu
branch
2 times, most recently
from
63c87d0 to
64ff8e5
Compare
Lain-B
approved these changes
Nov 10, 2024
Warchamp7
force-pushed
the
preview-context-menu
branch
3 times, most recently
from
b29d332 to
bb100ae
Compare
Warchamp7
force-pushed
the
preview-context-menu
branch
5 times, most recently
from
6b91888 to
2f4373f
Compare
Warchamp7
force-pushed
the
preview-context-menu
branch
from
2f4373f to
d02e1c6
Compare
Warchamp7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganizes the order of menu items in the Preview and Source right-click context menus. On top of adjustments to menu entry order, functional changes are:
Copy filters/Paste filtersonly shown in the sources dock menu and only when a source is selectedCopyonly shown when a source is selectedSet Colorremoved from preview menusHide in Mixerremoved from preview menusMotivation and Context
A lot of entries in the preview context menu have been added over time and their order and position are only loosely tied together.
While there is no perfect ordering or grouping here due to overlapping contexts and functionality. This reorganizes the menu to be a bit more thoughtful.
Preview (No source selected)
Sources dock (No source selected)
Preview (Source selected)
Sources dock (Source selected)
How Has This Been Tested?
Checked all the menu options still behaved as expected.
Types of changes
Checklist: