Decklink: Convert to frame scheduling and use preroll [DRAFT]#4565
Closed
tt2468 wants to merge 1 commit intoobsproject:masterfrom
Closed
Decklink: Convert to frame scheduling and use preroll [DRAFT]#4565tt2468 wants to merge 1 commit intoobsproject:masterfrom
tt2468 wants to merge 1 commit intoobsproject:masterfrom
Conversation
|
Tested on OBS 27.2.0-beta2 Debian 11. |
Member
Author
Decklink output currently enables the frame scaler 24/7, regardless of whether it is required. I'll be working on a change to only enable it when necessary soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a draft. I am using it to produce test builds for windows.
Changes:
Current Issues:
bmdOutputFrameDisplayedLate, however frames are never actually dropped by decklink.Fixed Issues:
Motivation and Context
The current decklink output implementation synchronously writes data to decklink. The correct method is to schedule frames with timestamps, and let decklink handle writing the scheduled frames. This PR uses reference from #1865, with additional fixes and changes that I've made during my own testing process.
How Has This Been Tested?
I run an AV sync test on loop on a media source, outputting via a Decklink Duo 2 to a display. Measuring sync with my phone's slow motion recording.
Types of changes
Checklist: