Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Enable control of transitions audio properties #9192

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Penwy
Copy link
Contributor

@Penwy Penwy commented Jul 2, 2023

Description

This aims to implement a standardised way to control the audio properties (mono, volume, balance, offset, monitoring and mixer channels) of transition sources (or rather, of their child sources).

Audio properties are saved as data settings of the transition source (transitions, being composite sources cannot hold audio properties of their own), and it's left to the transition's implementation to apply those to the relevant child sources, either on source_update, or on a custom procedure, transition_audio_update (provided as a means to update the child sources audio properties without doing a full update).

From a UI/UX standpoint, this adds an entry in the transition properties menu (provided that the transition has the OBS_TRANSITION_HAS_AUDIO flag):
Workspace 1_008
This entry then opens a dialog similar to the advanced audio properties, tied to the transition's audio properties
Selection_1244

Motivation and Context

Control of transition volume can be useful as a lot of transition are provided as premade packs and might not fit the user's audio setup.
Control of transition mixer tracks is undeniably useful for editing or VoD audio isolation purposes.
Control of transition monitoring was pre-existing for stingers, but this provides a standardised way to enable it for future or third-party transitions.
The rest is probably less useful, but felt a decent addition to have full advanced audio control.

This was based on and expanded from the suggestions :
https://ideas.obsproject.com/posts/495/stinger-transition-audio-controls
https://ideas.obsproject.com/posts/1435/stinger-transition-audio-controller

How Has This Been Tested?

Tested on Ubuntu 22.04.
Tested by using a stinger video with audio and checking all audio setting applied correctly and persisted on save/load.
Linked below is a good media file for testing purposes if need be.
stinger_countdown.webm

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Documentation (a change to documentation pages)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Penwy Penwy force-pushed the transition-audio-properties branch from 79d894c to dfcc2a9 Compare July 2, 2023 02:25
@Fenrirthviti Fenrirthviti added the UI/UX Anything to do with changes or additions to UI/UX elements. label Jul 2, 2023
@WizardCM WizardCM added the New Feature New feature or plugin label Jul 8, 2023
@LukiEnLive
Copy link

we need this !
Because sometimes we cannot directly modify the source file of the transition because some formats are not editable with software 😢

@Penwy Penwy force-pushed the transition-audio-properties branch from dfcc2a9 to d18a460 Compare October 20, 2024 09:31
@Warchamp7 Warchamp7 self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants