Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Scene Items per ID, in addition to scene name and source name #449

Merged
merged 11 commits into from
Mar 29, 2020
Merged

Target Scene Items per ID, in addition to scene name and source name #449

merged 11 commits into from
Mar 29, 2020

Conversation

Palakis
Copy link
Contributor

@Palakis Palakis commented Mar 29, 2020 •
edited
Loading

I went through the spec of all scene item request types and events. All scene items events are fine. There are three request types to fix:

In these three request types, allow the item param to either be:

  • A string, targeting the first scene item available by this name (current/legacy behaviour)
  • An object, borrowing the spec used for the item request field in DeleteSceneItem and DuplicateSceneItem
    • For consistency, backport new behaviour to DeleteSceneItem and DuplicateSceneItem

Fixes #154
Fixes #398

@Palakis Palakis added the bug label Mar 29, 2020
@Palakis Palakis added this to the 4.8 milestone Mar 29, 2020
@Palakis Palakis self-assigned this Mar 29, 2020
@Palakis
docs(clarity): move scene items events into a proper "Scene Items" ca…
3709ea1 
…tegory

Namely:
- SourceOrderChanged
- SceneItemAdded
- SceneItemRemoved
- SceneItemVisibilityChanged
- SceneItemLockChanged
- SceneItemTransformChanged
- SceneItemSelected
- SceneItemDeselected
@Palakis
requests(scene items): refactor docs
c486bc6
@Palakis
requests(scene items): doc fixes again
a6c6a42
@Palakis Palakis force-pushed the bugfix/get-set-sceneitemproperties-item-id branch from e3fe6fd to a6c6a42 Compare March 29, 2020 17:40
@Palakis Palakis marked this pull request as ready for review March 29, 2020 22:03
@Palakis Palakis merged commit e467666 into 4.x-current Mar 29, 2020
@Palakis Palakis deleted the bugfix/get-set-sceneitemproperties-item-id branch March 29, 2020 22:20
@obsproject obsproject deleted a comment from alfalah919 Dec 15, 2020
@obsproject obsproject deleted a comment from alfalah919 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Palakis Palakis

Labels
None yet
Projects
None yet
Milestone
4.8
1 participant
@Palakis