#300 fix: S3Proxy is not compatible with official AWS' extended library #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwiercinski
force-pushed
the
s3_compability_bug
branch
2 times, most recently
from
1744d9d to
6868d81
Compare
bwiercinski
force-pushed
the
s3_compability_bug
branch
from
bc4002f to
969aa00
Compare
matwojcik
approved these changes
May 11, 2023
addons/s3proxy/src/main/scala/com/ocadotechnology/pass4s/s3proxy/S3Syntax.scala
Outdated
Show resolved
Hide resolved
bwiercinski
force-pushed
the
s3_compability_bug
branch
2 times, most recently
from
8c51bb6 to
16fb8c2
Compare
bwiercinski
force-pushed
the
s3_compability_bug
branch
from
16fb8c2 to
f77bb67
Compare
bwiercinski
force-pushed
the
s3_compability_bug
branch
from
f77bb67 to
cde0571
Compare
|
Looks great! Please add a section to migration guide on how to adapt to the new version and we'll be good to merge |
majk-p
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #300. There are 2 formats of a pointer:
{"s3BucketName": "bucket", "s3Key": "key"}sender.usingS3Proxy(...)is still using the legacy format, but is the method deprecatedsender.usingS3ProxyCustomEncoder(...)allowing user to use the correct format