feat: Upgrade to Django 2.2 #1132
Conversation
# Conflicts: # Pipfile # Pipfile.lock # game/__init__.py
Codecov Report
@@ Coverage Diff @@
## django_2_upgrade #1132 +/- ##
====================================================
+ Coverage 91.19% 91.31% +0.12%
====================================================
Files 110 111 +1
Lines 6155 6197 +42
====================================================
+ Hits 5613 5659 +46
+ Misses 542 538 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed 19 of 28 files at r1.
Reviewable status: 19 of 28 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
setup.py, line 24 at r1 (raw file):
include_package_data=True, install_requires=[ "django>=1.11.24, <= 2.0.0",
we only need to support 2.0 if we are running a long-running feature branch
There was a problem hiding this comment.
Reviewable status: 19 of 28 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @mrniket)
setup.py, line 24 at r1 (raw file):
Previously, mrniket (Niket Shah) wrote…
we only need to support 2.0 if we are running a long-running feature branch
Done.
There was a problem hiding this comment.
Reviewed 27 of 28 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @mrniket)
example_project/example_project/urls.py, line 12 at r2 (raw file):
urlpatterns = [ url(r"^", include(portal_urls)), url(r"^administration/", include((admin.site.urls[0], "admin"), namespace="admin")),
FYI: idea in portal PR.
game/migrations/0001_squashed_0025_levels_ordering_pt1.py, line 5081 at r2 (raw file):
( "first_level", models.ForeignKey(to="game.Level", on_delete=models.SET_NULL),
I think we also need null=True here if we use SET_NULL
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @razvan-pro)
example_project/example_project/urls.py, line 12 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
FYI: idea in portal PR.
Done :)
game/migrations/0001_squashed_0025_levels_ordering_pt1.py, line 5081 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
I think we also need
null=Truehere if we useSET_NULL
Actually, this field was removed from the Episode model in migration 0043 so I believe there is no need to specify this.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
game/migrations/0001_squashed_0025_levels_ordering_pt1.py, line 5081 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Actually, this field was removed from the Episode model in migration 0043 so I believe there is no need to specify this.
oh ok :)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
example_project/example_project/urls.py, line 12 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Done :)
administration 😊
There was a problem hiding this comment.
Reviewable status: 27 of 28 files reviewed, 1 unresolved discussion (waiting on @mrniket and @razvan-pro)
example_project/example_project/urls.py, line 12 at r2 (raw file):
Previously, mrniket (Niket Shah) wrote…
administration 😊
🙃
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 3 of 3 files at r5.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 33 files at r6, 32 of 33 files at r7, 5 of 5 files at r8.
Reviewable status:
This change is