Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct token for publishing packages #1139

Merged
merged 7 commits into from
Nov 27, 2020
Merged

Conversation

mrniket
Copy link
Contributor

@mrniket mrniket commented Nov 27, 2020

I have also neatened up the GitHub actions ci.yml file so that the job has a more semantic name and won't run on "semantic-release" commits


This change is Reviewable

Signed-off-by: Niket <niket.shah1@ocado.com>
Signed-off-by: Niket <niket.shah1@ocado.com>
Signed-off-by: Niket <niket.shah1@ocado.com>
Signed-off-by: Niket <niket.shah1@ocado.com>
Signed-off-by: Niket <niket.shah1@ocado.com>
Signed-off-by: Niket <niket.shah1@ocado.com>
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #1139 (2564323) into master (b51f2c9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   91.18%   91.19%   +0.01%     
==========================================
  Files         110      110              
  Lines        6158     6158              
==========================================
+ Hits         5615     5616       +1     
+ Misses        543      542       -1     
Impacted Files Coverage Δ
game/random_road.py 91.36% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51f2c9...8c3062b. Read the comment docs.

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mrniket mrniket merged commit af711cc into master Nov 27, 2020
@mrniket mrniket deleted the github_actions_publish branch November 27, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants