-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme, remove docker files and references #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @dionizh)
CONTRIBUTING.md, line 3 at r1 (raw file):
# Contributing Guidelines Thanks for helping out Code For life's Rapid Router! Here are a few guidelines to help your contributions to be accepted :)
Capital L for "Life" pls
CONTRIBUTING.md, line 7 at r1 (raw file):
## Prerequisites We use Zenhub to track our issues, you can find [our workspace here](https://github.com/ocadotechnology/rapid-router#workspaces/code-for-life-development-56f2afba6e54555c586f6db3/board?repos=39072690,22154147,18399425,49142916,219226351).
Do we want to specify that Zenhub needs to be added as Chrome extension?
README.md, line 10 at r1 (raw file):
## Code for Life and Rapid Router Overview - Rapid Router is a [Code for Life](c4l) project, aimed at teaching primary-school children programming concepts through a vehicle routing
no hyphen between primary and school pls
README.md, line 11 at r1 (raw file):
- Rapid Router is a [Code for Life](c4l) project, aimed at teaching primary-school children programming concepts through a vehicle routing game.
Is this word on a new line?
README.md, line 21 at r1 (raw file):
## How to play Go to [Code For Life website][c4l]. Register as either teacher or independent student. Go to Rapid Router to play.
Do we want to mention that signing up is optional to play the game?
README.md, line 43 at r1 (raw file):
### Mac - Get the [brew](https://brew.sh/) package manager.
Don't you have to install Python on Macs too / wasn't there an issue that you had when setting up RR and portal to do with SQL or something?
README.md, line 84 at r1 (raw file):
You can also [submit a feature request][add-issue]. Make sure that you give us a suitable level of detail about the feature. Please note that we may not act upon all suggestions, if they are not in line with the direction we want to take the project, or if we don't have the development resources to get it done.
Is this on a new line too?
Codecov Report
@@ Coverage Diff @@
## master #1178 +/- ##
==========================================
+ Coverage 91.29% 91.30% +0.01%
==========================================
Files 111 111
Lines 6200 6200
==========================================
+ Hits 5660 5661 +1
+ Misses 540 539 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 7 unresolved discussions (waiting on @faucomte97)
CONTRIBUTING.md, line 3 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Capital L for "Life" pls
Done.
CONTRIBUTING.md, line 7 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Do we want to specify that Zenhub needs to be added as Chrome extension?
Done.
README.md, line 10 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
no hyphen between primary and school pls
Done.
README.md, line 11 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Is this word on a new line?
Done.
README.md, line 21 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Do we want to mention that signing up is optional to play the game?
Done.
README.md, line 43 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Don't you have to install Python on Macs too / wasn't there an issue that you had when setting up RR and portal to do with SQL or something?
Done.
README.md, line 84 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Is this on a new line too?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dionizh)
This change is