fix: Make Scoreboard logic more efficient #1279
Conversation
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
game/templates/game/level_selection.html, line 54 at r2 (raw file):
{% block header %} <div class="banner banner--rapid-router--background"> <section class="level_rr_logo">
As section aligns the text to center, can you remove the related css class that does that (level_rr_logo)
game/views/scoreboard.py, line 107 at r2 (raw file):
def scoreboard_data(episode_ids, attempts_per_students):
Good combining these two! I was thinking about it.
game/views/scoreboard.py, line 141 at r2 (raw file):
total_possible_score = 0 # Get the best attempts for the specific Episode attempts_dict = [
Not a dict, incorrect name.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dionizh)
game/templates/game/level_selection.html, line 54 at r2 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
As
sectionaligns the text to center, can you remove the related css class that does that (level_rr_logo)
Done.
game/views/scoreboard.py, line 107 at r2 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Good combining these two! I was thinking about it.
😊
game/views/scoreboard.py, line 141 at r2 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Not a dict, incorrect name.
Done.
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @dionizh and @faucomte97)
game/static/game/css/level_selection.css, line 98 at r3 (raw file):
} .banner--rapid-router--background img {
Sorry, this is minor, but let's not call it background as it's actually foreground. Just banner--rapid-router is fine I think.
game/static/game/css/scoreboard.css, line 1 at r3 (raw file):
.banner--rapid-router--background img {
Same here.
game/templates/game/level_selection.html, line 53 at r3 (raw file):
{% block header %} <div class="banner banner--rapid-router--background">
Can we have all these in the section and remove the div?
game/templates/game/scoreboard.html, line 33 at r3 (raw file):
{% block header %} <div class="banner banner--rapid-router--background"> <section>
Same here.
There was a problem hiding this comment.
Reviewable status: 3 of 7 files reviewed, 5 unresolved discussions (waiting on @dionizh)
game/static/game/css/level_selection.css, line 98 at r3 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Sorry, this is minor, but let's not call it
backgroundas it's actually foreground. Justbanner--rapid-routeris fine I think.
Done.
game/static/game/css/scoreboard.css, line 1 at r3 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Same here.
Done.
game/templates/game/level_selection.html, line 53 at r3 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Can we have all these in the section and remove the div?
Done.
game/templates/game/scoreboard.html, line 33 at r3 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Same here.
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
+ Coverage 90.63% 90.65% +0.01%
==========================================
Files 98 98
Lines 5318 5318
==========================================
+ Hits 4820 4821 +1
+ Misses 498 497 -1
|
This change is