Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create failed attempt on crash, out of fuel and red light events #1280

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Jan 11, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Jan 11, 2022
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1280 (f24c517) into master (31f077b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
+ Coverage   90.63%   90.67%   +0.03%     
==========================================
  Files          98       98              
  Lines        5318     5317       -1     
==========================================
+ Hits         4820     4821       +1     
+ Misses        498      496       -2     
Impacted Files Coverage Δ
game/views/level.py 61.45% <ø> (+0.31%) ⬆️
game/end_to_end_tests/selenium_test_case.py 100.00% <100.00%> (ø)
game/random_road.py 91.36% <0.00%> (+0.35%) ⬆️

@faucomte97 faucomte97 merged commit 04ce387 into master Jan 11, 2022
@faucomte97 faucomte97 deleted the create_attempt_on_crash branch January 11, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants