Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix custom level save bugs #1372

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: Fix custom level save bugs #1372

merged 1 commit into from
Oct 10, 2022

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Oct 10, 2022 •
edited
Loading

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Oct 10, 2022
@faucomte97 faucomte97 marked this pull request as ready for review October 10, 2022 14:00
KamilPawel
KamilPawel approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1372 (485571f) into master (7bcd10a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
+ Coverage   91.80%   91.82%   +0.02%     
==========================================
  Files          98       98              
  Lines        5453     5457       +4     
==========================================
+ Hits         5006     5011       +5     
+ Misses        447      446       -1
Impacted Files Coverage Δ
game/views/level_editor.py 72.46% <100.00%> (+0.54%) ⬆️
game/random_road.py 91.36% <0.00%> (+0.35%) ⬆️

@faucomte97 faucomte97 merged commit ee4079a into master Oct 10, 2022
@faucomte97 faucomte97 deleted the fix_editor_bug branch October 10, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilPawel KamilPawel KamilPawel approved these changes

Assignees

@faucomte97 faucomte97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faucomte97 @KamilPawel