Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynArray.{left,right,tail} need user input checks #987

Merged
merged 3 commits into from
Nov 16, 2020
Merged

DynArray.{left,right,tail} need user input checks #987

merged 3 commits into from
Nov 16, 2020

Conversation

fccm
Copy link
Member

@fccm fccm commented Nov 15, 2020 •
edited
Loading

Dangerous functions if we don't check user input, because unsafe assignments are used.

@UnixJunkie
Copy link
Member

Thanks for the improvements.
The corresponding ocamldoc could mention which function throws which exception and under what conditions.

@UnixJunkie UnixJunkie merged commit ab54823 into ocaml-batteries-team:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fccm @UnixJunkie