Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating the hanging of the
coq
build with Multicore OCaml, under some specific scenario, it turns out updatingdune
to 2.9.0 fixes the issue.This specific hang is still a bit of a mystery to me, but it seems like the failure to build
coq
with Multicore triggers a loop in a retry mechanism indune
's fibers.I also noticed that we still have a system dune in place to work around past compatibility issues with
4.09.0
and Multicore not being able to builddune
by itself.It does seems the dune version used by the sandmark run is indeed the one installed in the switch. (and not the system dune)
I was wondering if there was a reason why we still have the system dune setup active in sandmark? I assume it is still useful for trunk (since dune may break against trunk), however Multicore+dune compatibility is not an issue anymore.