Migrate from Jbuilder to Dune #24
Conversation
This commit migrates the project from Jbuilder to Dune, as Jbuilder will be discontinued in July. Note that when I use OCaml 4.08.0, I get deprecation notices, yet running `make`, then `make install`, seems to work anyway.
|
Looking great. Thank you very much.
Please do so. I think it's better to stick with default warnings as much as possible (at least in a small code base like this one).
We should fix this separately. Would you mind filing an issue for that? Otherwise I'll do it. |
…bles I also added a newline to fix a warning about an ambiguous documentation comment, which was intended for the map function in the List module. There are also warnings about unused names in the List module, which are intended to shadow names from the standard library. I've disabled those warnings for now.
|
Oh yeah, sorry, I forgot to mention: You have a List module that shadows the List module of the standard library while replacing certain functions with tail-recursive versions. However, none of these functions seem to be used in the rest of the code, and when I use Dune, I get a warning about unused names. However, if I were to remove the module, then someone might use the functions later and end up using the versions from the standard library. Should I keep or remove the module? |
|
This |
|
I have removed the List module. |
|
(Don't forget to publish the changes on OPAM.) |
|
I don't have time for it. I will only do the minimum to help transfer the repo to ocaml-community or to another account or organization. |
CHANGES: - Port from jbuilder to dune. (ocaml-community/easy-format#24) - Port to opam 2.0 and make dune a non build dependency (ocaml-community/easy-format#25)
CHANGES: - Port from jbuilder to dune. (ocaml-community/easy-format#24) - Port to opam 2.0 and make dune a non build dependency (ocaml-community/easy-format#25)
This commit migrates the project from Jbuilder to Dune, as Jbuilder will be
discontinued in July.
When switching from Jbuilder to Dune, I encountered warnings about record labels not listed in patterns, which I surpressed in the
dunefile. Do you want me to add; _to the record patterns to deal with the warning?I also got a warning in
examples/simple_example.mlbecause of an unused variablei, which I replaced with a wildcard.Note that when I run
makewhile using OCaml 4.08, I get deprecation notices regarding the Format module, but the package seems to install anyway. This issue seems to be unrelated to migration from Jbuilder to Dune.