Fix spec 353: ASCII character 160, non-breaking space, is white space #247
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generation of tests wasn't documented. This documents it and scripts it.
The spec requires the nonbreaking whitespace character, ASCII code 160 to be recognized as white space. https://en.wikipedia.org/wiki/Non-breaking_space
shonfeder
force-pushed
the
235/fix-spec-353
branch
from
fc6050c to
dc03372
Compare
shonfeder
changed the title
sonologico
approved these changes
May 30, 2021
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jun 25, 2021
CHANGES: - Clean up AST representation (ocaml-community/omd#229, @sonologico) - Restore table of contents generation functionality (ocaml-community/omd#240, @sonologico) - Fix parsing of <...>-style links and inline code parsing (ocaml-community/omd#233, @SquidDev) - Fix handing of the nonbreaking whitespace character, ASCII code 160 (ocaml-community/omd#247, @shonfeder) - Downgrade dune requirements to 2.0 (@nobj)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing verification of spec unit 353. See 2441975 for details.
Turned up while refactoring issue #235 into smaller work items.
This PR also adds make targets to streamline regeneration of tests and