CI and README for 64bits only cleanup #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
previously approved these changes
Feb 5, 2025
| @@ -1,18 +1,18 @@ | |||
| opam-cross-windows | |||
| ================== | |||
|
|
|||
| This repository contains an up-to-date Windows toolchain featuring OCaml `4.07.0`, `4.08.0`, `4.12.0`, `4.14.0` and `5.1.1`, as well as some commonly used packages. | |||
| This repository contains an up-to-date Windows toolchain featuring OCaml `4.07.0`, `4.08.0`, `4.12.0`, `4.14.1`, `5.1.1` and `5.3.0`, as well as some commonly used packages. | |||
There was a problem hiding this comment.
At some point we should consider pruning like the main opam repo is doing.
.github/workflows/ci.yml
Outdated
| @@ -38,7 +38,7 @@ jobs: | |||
| # ocaml compiler 4.14.1 does not have an option to build in 32 bit mode anymore. | |||
| ocaml_version: [4.14.1, 5.3.0] | |||
| container: | |||
| image: ocamlcross/windows-x64-base:${{ matrix.ocaml_version }} | |||
There was a problem hiding this comment.
I think it's nice to keep indicating the arch here. Helps the user preemptively making choices.
|
|
||
| If you need support for other platforms or versions, please [open an issue](https://github.com/ocaml-cross/opam-cross-windows/issues). | ||
|
|
||
| Prerequisites | ||
| ------------- | ||
|
|
||
| A C cross-compiler targeting the appropriate Windows platform must be installed. On Debian derivatives they are provided in the `gcc-mingw-w64-i686` (for 32-bit x86 Windows targets) or `gcc-mingw-w64-x86-64` (for 64-bit x86 Windows targets) packages. Alternatively, the [MXE environment](http://mxe.cc) can be used. | ||
| A C cross-compiler targeting the appropriate Windows platform must be installed. On Debian derivatives they are provided in the `gcc-mingw-w64-x86-64` packages (`gcc-mingw-w64-i686` for 32-bit x86 Windows targets). Alternatively, the [MXE environment](http://mxe.cc) can be used. |
There was a problem hiding this comment.
I think that we should remove all x86 documentation and support but perhaps not for this PR.
pirbo
force-pushed
the
CI-64only-cleanup
branch
from
1ef3e1f to
c9587cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am agnostic to the renaming of the docker images. Take the commint at will :)