Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move h1 Title Rendering to the Correct Location #137

Merged
merged 4 commits into from
Jan 28, 2024

Conversation

sabine
Copy link
Collaborator

@sabine sabine commented Jan 14, 2024

  • repairs the test case that included an index.mld file by adding the missing dune file that tells odoc about the presence of mld pages
  • extends test cases to check for the output generated for index.mld (both auto-generated and existing index.mld)
  • moves the h1 title rendering logic to the correct place

Resolves #133

Depends on #136

@sabine sabine force-pushed the remove_h1_title_rendering branch 2 times, most recently from 9500eec to 78a1421 Compare January 21, 2024 19:38
@sabine sabine force-pushed the remove_h1_title_rendering branch from 78a1421 to 162e0d0 Compare January 21, 2024 19:54
@sabine sabine force-pushed the remove_h1_title_rendering branch from 162e0d0 to 42155ae Compare January 28, 2024 17:25
@sabine sabine merged commit f7a7a09 into ocaml-doc:main Jan 28, 2024
1 of 3 checks passed
@sabine sabine deleted the remove_h1_title_rendering branch January 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't emit an extra H1 title for index.html.json
1 participant