Make parallel_scan work on noncommutative functions #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sudha247
approved these changes
Aug 31, 2023
Contributor
Sudha247
left a comment
Sudha247
left a comment
There was a problem hiding this comment.
Good catch! Looks good to me.
shonfeder
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Apr 10, 2025
CHANGES: * Upgrade to Saturn 1.0 (ocaml-multicore/domainslib#129, @Sudha247) * Update README.md instruction to use OCaml 5.1.0 (ocaml-multicore/domainslib#123, @punchagan) * Fix Saturn.Queue function (ocaml-multicore/domainslib#121, @Sudha247) * Make parallel_scan work on noncommutative functions (ocaml-multicore/domainslib#118, @aytao) * Test condition tweaks (ocaml-multicore/domainslib#113, @jmid) * Adjust PBTs based on recommended_domain_count (ocaml-multicore/domainslib#112, @jmid)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #116
Previously, a single incorrect parameter ordering in Task.parallel_scan meant that the provided operation had to be both associative and commutative. This PR fixes this so that parallel_scan is now still correct for noncommutative functions.