Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform subprocess support #499

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

talex5
Copy link
Collaborator

@talex5 talex5 commented May 2, 2023

This is based on @patricoferris's #473, but rebased on top of #498 and with some changes:

  • The standard streams are now optional, and default to inheriting from the parent.
  • The executable is optional, and searched for in $PATH from the first argument if not given.
  • Process.parse_out provides an easy way to parse the output of a process.
  • The logic for converting flows to pipes is now shared in Eio_unix.

This also splits Eio_unix into separate modules.

@talex5 talex5 added the enhancement New feature or request label May 2, 2023
@talex5 talex5 requested a review from patricoferris May 2, 2023 14:32
@talex5 talex5 force-pushed the proc-redux branch 2 times, most recently from cd1a9df to b0f3832 Compare May 3, 2023 10:14
@talex5 talex5 mentioned this pull request May 3, 2023
Copy link
Collaborator

@patricoferris patricoferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great, I like the parse_out API.

lib_eio/process.mli Show resolved Hide resolved
lib_eio/process.mli Show resolved Hide resolved
tests/process.md Show resolved Hide resolved
@talex5 talex5 force-pushed the proc-redux branch 3 times, most recently from 0209fd7 to a07de9f Compare May 4, 2023 12:58
This also splits Eio_unix into separate modules.

Co-authored-by: Thomas Leonard <talex5@gmail.com>
@talex5 talex5 merged commit 7ea93f2 into ocaml-multicore:main May 4, 2023
@talex5 talex5 deleted the proc-redux branch May 4, 2023 16:51
@talex5 talex5 mentioned this pull request May 4, 2023
5 tasks
@talex5 talex5 added this to the 0.10 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants