Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lockfree tests #265

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Remove lockfree tests #265

merged 4 commits into from
Dec 21, 2022

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Dec 12, 2022

I've created a PR to move the lockfree Ws_deque test to that repo, now that we have released qcheck-stm 0.1.0:
ocaml-multicore/saturn/pull/43, thus addressing the first half of #193.

This PR thus

  • removes the test code
  • cleans up its dependencies from multicoretests
  • cleans up mention and pointers to the tests from README-markdown files

I've created the branch lockfree-tests as a name for the most recent main with the tests still present.

@jmid
Copy link
Collaborator Author

jmid commented Dec 12, 2022

CI is failing because domainslib depends on lockfree which then pulls in the broken, transitive containers dependency...

@jmid jmid mentioned this pull request Dec 12, 2022
@jmid jmid force-pushed the rm-lockfree-tests branch from 56292b4 to 3b478ab Compare December 20, 2022 19:39
@jmid
Copy link
Collaborator Author

jmid commented Dec 21, 2022

The only failure is the well-known threadomain timeout on Windows so I'll merge.
Multiple runs on MacOS and Linux are taking less than 40min now with the removal of both the Domainslib and Lockfree tests and their dependency installation.

@jmid jmid merged commit a29ad25 into main Dec 21, 2022
@jmid jmid deleted the rm-lockfree-tests branch December 21, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant