Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on Lin Bytes test and add stress test #521

Merged
merged 10 commits into from
Jan 19, 2025
Merged

Expand on Lin Bytes test and add stress test #521

merged 10 commits into from
Jan 19, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jan 16, 2025

While looking at #520 I noticed the long-running Lin Bytes test contains only few of the Bytes module binding.
This PR adds a bunch more.

Adding these seem to have a positive effect on quickly reducing a counterexample, when I run this locally.
As such, it may help resolve #520.

While at it, the PR also adds a Lin stress_test of these many bindings (now well beyond what src/bytes/stm_tests.ml covers).

@jmid jmid changed the title Expand on Bytes test and add stress test Expand on Lin Bytes test and add stress test Jan 16, 2025
@jmid jmid mentioned this pull request Jan 16, 2025
@jmid
Copy link
Collaborator Author

jmid commented Jan 17, 2025

CI summary

Out of 34 workflows 1 failed with a false alarm

@jmid jmid force-pushed the bytes-test-adjust branch from 7b2e3d6 to 0cada98 Compare January 18, 2025 14:33
@jmid
Copy link
Collaborator Author

jmid commented Jan 18, 2025

Force pushed a dummy change to trigger a test rerun, as the Cygwin workflows seem to have now settled from whatever was troubling them... 🤔

@jmid
Copy link
Collaborator Author

jmid commented Jan 18, 2025

CI summary for 0cada98

  • MSVC bytecode trunk failed to find a counterexample for Lin Bytes test with Domain in 2500 iterations

@jmid
Copy link
Collaborator Author

jmid commented Jan 18, 2025

2777159 thus bumps the count to 5000

@jmid
Copy link
Collaborator Author

jmid commented Jan 19, 2025

CI summary for 2777159

Out of 34 workflows 1 failed with what may be a genuine error

@jmid
Copy link
Collaborator Author

jmid commented Jan 19, 2025

As the Lin Bytes test is working nicely - and since the Lin Dynarray test failure is unrelated, I'll go ahead and merge this.

@jmid jmid merged commit 05a5ac9 into main Jan 19, 2025
33 of 34 checks passed
@jmid jmid deleted the bytes-test-adjust branch January 19, 2025 20:11
@jmid
Copy link
Collaborator Author

jmid commented Jan 19, 2025

CI summary for merge to main: all 35 workflows passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout due to excessive shrinking in Lin Bytes test with Domain on Cygwin
1 participant