Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit buffer test #70

Closed
wants to merge 3 commits into from
Closed

Omit buffer test #70

wants to merge 3 commits into from

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented May 17, 2022

The Buffer test can trigger a segfault as described in #63.
This KR therefore

The hypothesis is that collectively the two will restore green CI lights for MacOS... 🤞

@jmid
Copy link
Collaborator Author

jmid commented May 18, 2022

This is still failing with a segfault https://github.com/jmid/multicoretests/runs/6479465240?check_suite_focus=true#step:6:916

New hypothesis:

  • this is caused by src/lazy_lin_test.ml
  • it is tied to raising exceptions (here CamlinternalLazy.Undefined)
  • it happens when finishing the test (completing the run of the first of 3 variants - so not at exit)

Still not reproducible locally - so trying to add missing handlers (while crossing fingers...)

@jmid
Copy link
Collaborator Author

jmid commented May 18, 2022

@jmid
Copy link
Collaborator Author

jmid commented Jun 1, 2022

Closing as the MacOS CI is no longer segfaulting after switching to the alpha repo.

@jmid jmid closed this Jun 1, 2022
@jmid jmid deleted the omit-buffer-test branch July 11, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant