Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin flag to opam-0install #34

Closed
wants to merge 1 commit into from

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Nov 26, 2021

No description provided.

@talex5
Copy link
Collaborator

talex5 commented Nov 29, 2021

What's this for? I thought the solver was available as a built-in now anyway?

@dra27
Copy link
Member Author

dra27 commented Nov 29, 2021

The opam package is named opam-0install which means it's capable of being invoked as a plugin (i.e. as opam 0install with opam automatically delegating the command line to it) and we (opam) had a bug report with it being used that way, so I assumed it intended to be used as a plugin?

There may be errors in assumption at any stage of this!

@dra27
Copy link
Member Author

dra27 commented Nov 29, 2021

I was following a regression related to ocaml/opam#4554 - the command shown in there doesn't work in opam 2.1 because opam 2.1 is more pernickety about the plugin flag being specified than opam 2.0.

@talex5
Copy link
Collaborator

talex5 commented Nov 29, 2021

Hmm. It's not supposed to be used as a plugin!

That command doesn't work for me in opam 2.0 either, though:

$ docker run --rm -it ocaml/opam
opam@7a58ad95d269:~$ opam --version
2.0.10
opam@7a58ad95d269:~$ opam 0install dune
[ERROR] 0install is not a known command or plugin (package opam-0install.0.4.2 does not have the 'plugin' flag set).

Maybe it's a typo in the issue?

@dra27
Copy link
Member Author

dra27 commented Nov 29, 2021

Ah, my bad - in which case this and the opam-repository PR can be closed, and sorry for the noise!

@dra27 dra27 closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants