Add support for objects and classes #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #13 |
|
Excellent, looking great! I couldn't check in great detail, but reading through the implementation I did not see anything concerning or notice any lurking gotchas. |
hhugo
changed the title
|
Certainly not perfect, not bug free, but I think I'm done the initial support. |
jberdine
reviewed
May 5, 2018
src/Ast.ml
Outdated
| @@ -202,10 +244,14 @@ end = struct | |||
|
|
|||
| let sub_typ ~ctx typ = check parenze_typ {ctx; ast= typ} | |||
|
|
|||
| let sub_cty ~ctx typ = {ctx; ast= typ} | |||
There was a problem hiding this comment.
nit: naming a class_type typ is intended?
src/Ast.ml
Outdated
| let sub_pat ~ctx pat = check parenze_pat {ctx; ast= pat} | ||
|
|
||
| let sub_exp ~ctx exp = check parenze_exp {ctx; ast= exp} | ||
|
|
||
| let sub_cl ~ctx typ = {ctx; ast= typ} |
There was a problem hiding this comment.
nit: naming a class_expr typ is intended?
src/Ast.ml
Outdated
| @@ -755,6 +1053,15 @@ end = struct | |||
| | Some (Some true) -> true | |||
| | _ -> false | |||
|
|
|||
| (** [parenze_cty {ctx; ast}] holds when type [ast] should be parenthesized | |||
There was a problem hiding this comment.
nit: s/when type/when class type/ ?
src/Ast.ml
Outdated
| @@ -989,6 +1325,15 @@ end = struct | |||
| else exposed_right_exp Non_apply exp ) | |||
| | _ -> false | |||
|
|
|||
| (** [parenze_cl {ctx; ast}] holds when type [ast] should be parenthesized | |||
There was a problem hiding this comment.
nit: s/when type/when class expr/ ?
src/Fmt_ast.ml
Outdated
| (Format.asprintf "%t" (Cmts.preserve (fun () -> fmt_expression c xe))) | ||
| in | ||
| let fmt_args_grouped e0 a1N = | ||
| (* TODO: consider [e0] when groupping *) |
There was a problem hiding this comment.
nit: s/groupping/grouping .
This is nontrivial due to the different types of e0 and a1N, right? Any other reason?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early preview. Feedback and contributions are welcome