Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: switch to dune, use dev and release instead of dbg and opt #186

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

jberdine
Copy link
Collaborator

@jberdine jberdine commented May 6, 2018

Preview of simplifications enabled by ocaml/dune#419

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@jberdine jberdine changed the title [WIP] Build: simplify using dune profiles Build: switch to dune, use dev and release instead of dbg and opt Jul 25, 2018
@hhugo
Copy link
Collaborator

hhugo commented Jul 26, 2018

lgtm

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jberdine jberdine merged commit eb63116 into master Jul 26, 2018
@jberdine jberdine deleted the dune-profile branch July 26, 2018 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants